I18N: Annotate literals in advisory command #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment is extracted by "xgettext -c" and placed to gettext
catalogs. It helps the translators not know which words not to
translate:
#. Note for translators: "critical" etc. quoted words are
#. literals that should not be translated.
#: commands/advisory/arguments.hpp:155
msgid ""
"Limit to packages in advisories with specified severity. List option. Can be "
"\"critical\", \"important\", \"moderate\", \"low\", \"none\"."
msgstr ""
Fixes: rpm-software-management#1159
ppisar
force-pushed
the
translator_hint
branch
from
056b4ce to
69120f9
Compare
|
How about making them placeholders |
|
LGTM |
|
Removing the literals from the message and substituting them dynamically would be bad because:
|
j-mracek
reviewed
Jan 17, 2024
| @@ -150,6 +150,8 @@ class AdvisorySeverityOption : public libdnf5::cli::session::AppendStringListOpt | |||
| command, | |||
| "advisory-severities", | |||
| '\0', | |||
| /* Note for translators: "critical" etc. quoted words are | |||
| literals that should not be translated. */ | |||
| _("Limit to packages in advisories with specified severity. List option. Can be " | |||
There was a problem hiding this comment.
I am curios whether we should use C_() to add a context for translators instead?
There was a problem hiding this comment.
Translation contexts are for distinguishing two identical messages for a need of different translations. This is not the case. This message only exists at two places dnf5/commands/advisory_shared.hpp and dnf5daemon-client/commands/advisory/arguments.hpp. The messages has the same meaning and use (their code and method name is actually a duplicate), so no artificial context is needed here.
Merged
via the queue into
rpm-software-management:main
with commit Jan 17, 2024
98c8612
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment is extracted by "xgettext -c" and placed to gettext catalogs. It helps the translators not know which words not to translate:
Fixes: #1159